Re: [PATCH] xfs: remove incorrect log write optimization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2010-07-12 at 12:04 -0400, Christoph Hellwig wrote:
> On Sun, Jul 11, 2010 at 10:30:00PM -0500, Alex Elder wrote:
> > On Mon, 2010-06-28 at 10:34 -0400, Christoph Hellwig wrote:
> > > We do need a barrier for the first buffer of a split log write.  Otherwise
> > > we might incorrectly stamp the tail LSN into transactions in the first
> > > block, or not flush data I/O before updating the inode size.
> > 
> > I'm not sure whether "first block" means the one at the beginning
> > of the log, or the one at the beginning of a split log write.
> 
> It means beginning of the split write.  I can fix up the commit message
> if you want.
> 

Don't bother, I will change it to:

We do need a barrier for the first buffer of a split log write.
Otherwise we might incorrectly stamp the tail LSN into transactions
in the first part of the split write, or not flush data I/O before
updating the inode size.


_______________________________________________
xfs mailing list
xfs@xxxxxxxxxxx
http://oss.sgi.com/mailman/listinfo/xfs


[Index of Archives]     [Linux XFS Devel]     [Linux Filesystem Development]     [Filesystem Testing]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux