On 07/12/2010 05:13 PM, Dave Chinner wrote: > On Mon, Jul 12, 2010 at 02:29:14PM -0500, Eric Sandeen wrote: >> On 07/09/2010 11:12 AM, Christoph Hellwig wrote >>> On Fri, Jul 02, 2010 at 12:48:55PM -0500, Eric Sandeen wrote: >>>>> What about just disabling selinux for all filesystems instead of just >>>>> XFS for the general case. >>>> >>>> Well it seems like if we -can- test with it on, that's good. >>>> Certain distros ship with it on by default, so exercising lots >>>> of scenarios with it on seems beneficial... >>> >>> It seems, but I'd rather do it consistently for all filesystems. >>> >> >> except we can't, because xfs actually has such low-level format checking >> that selinux -will- break it badly. >> >> I guess we could flag which tests can't run w/ extra xattrs, >> and only mount w/ the context for those? > > Maybe use a group to define all the tests that can't run with > selinux enabled and check it before running each test? i.e. use > notrun to prevent such tests from running. The attr group isprobably > a good start for the tests that will break w/ selinux enabled.... Something like that ... but there are more tests than just the attr group, I'm afraid. I'd have to re-run to see which break, guess I'll put that on the list. -Eric > Cheers. > > Dave. _______________________________________________ xfs mailing list xfs@xxxxxxxxxxx http://oss.sgi.com/mailman/listinfo/xfs
