Re: [PATCH v3 1/2] Documentation: coding-style: ask function-like macros to evaluate parameters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Mar 22, 2024 at 09:49:36PM +1300, Barry Song wrote:

> The driver code, for itself, seems be quite innocent and placing
> maybe_unused seems pointless,
> 
>  struct page *dst_page = sg_page(req->dst);
> 
>  for (i = 0; i < nr_pages; i++)
>  	flush_dcache_page(dst_page + i);
> 
> And it should be independent of architectural implementation
> differences.
> 
> Let's provide guidance on coding style for requesting parameter
> evaluation or proposing the migration to a static inline
> function.

Reviewed-by: Mark Brown <broonie@xxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux