On 25/07/2023 17:59, Jakub Kicinski wrote: > We repeatedly see noobs misuse get_maintainer by running it on > the file paths rather than the patchfile. This leads to authors > of changes (quoted commits and commits under Fixes) not getting > CCed. These are usually the best reviewers! > > The file option should really not be used by noobs, unless > they are just trying to find a maintainer to manually contact. > > Print a warning when someone tries to use -f and remove > the "auto-guessing" of file paths. > > This script may break people's "scripts on top of get_maintainer" > if they are using -f... but that's the point. > > Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx> > --- > This is what I had in mind. "Anything that can go wrong will go wrong." https://en.wikipedia.org/wiki/Murphy%27s_law Therefore: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> Best regards, Krzysztof
