On Tue, Jul 25, 2023 at 08:59:26AM -0700, Jakub Kicinski wrote: > We repeatedly see noobs misuse get_maintainer by running it on > the file paths rather than the patchfile. This leads to authors > of changes (quoted commits and commits under Fixes) not getting > CCed. These are usually the best reviewers! > > The file option should really not be used by noobs, unless > they are just trying to find a maintainer to manually contact. > > Print a warning when someone tries to use -f and remove > the "auto-guessing" of file paths. > > This script may break people's "scripts on top of get_maintainer" > if they are using -f... but that's the point. Ok, I'll go fix up my local scripts, but you should change your subject line to say "get_maintainer", not "checkpatch" :) thanks, greg k-h
