On 04.04.23 14:36, Konstantin Ryabitsev wrote: > On Tue, Apr 04, 2023 at 07:58:40AM +0200, Thorsten Leemhuis wrote: >> Would be great if bugbot could CC the regressions list for all bugs that >> have the regressions flag set to "yes" > I'll see if I can add this logic and make it configurable. great, thx! >> How does one make bugbot forward a bug to everyone in the signed-off-by >> chain of a commit that caused a regression, which might or might not >> have a bugzilla account? When the reporter performed a bisection these >> are the primary contacts that need to be reached out to, but the >> maintainers and lists for the subsystem obviously should be CCed. > > I can add a cf_bisected_commit field that can take a commit-id. When gathering > recipients, we can check if we know that commit in one of the tracked > repositories, and get the author field out of it. Would that be sufficient, Nearly, as mentioned above: it should be everybody in the signed-off-by chain (as explained in reporting-issues.rst), as that will catch co-developers and the people that handled the change on the way. > or do we need to run get_maintainer on it for a full picture? The normal magic you described that bugbot applies to match reports to subsystems is also needed, as otherwise lists and co-maintainer would not be in the loop. > Note, that you can also add addresses to Cc: on the thread -- they will be > collected behind the scenes as each message is processed and any bugbot > notifications originating from the bugzilla side will also include them. That's good to know and likely will be handy sometimes, but well, for regular use of the bugzilla->mailing list use-case it would be slightly annoying if you'd first have to tell bugzilla to create a ml thread, which you then need to find to write a reply to add people to the CC. Ciao, Thorsten
