Re: RFC: Github PR bot questions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


On Wed, Jun 16, 2021 at 3:18 PM Stefano Stabellini
<sstabellini@xxxxxxxxxx> wrote:
> On Wed, 16 Jun 2021, Rob Herring wrote:
> > > - subsystem maintainers can configure whatever CI pre-checks they want before
> > >   the series is sent to them for review (and we can work on a library of
> > >   Github actions, so nobody needs to reimplement multiple times)
> >
> > What about all the patches that don't come from the GH PR? Those need
> > CI pre-checks too. We're going to implement CI twice? The biggest
> > issue I have on CI checks is applying patches. My algorithm is apply
> > to my current base (last rc1 typically) or give up. I'm sure it could
> > be a lot smarter trying several branches or looking at base-commit
> > (not consistently used) or the git diff treeish hashes. What I'd
> > really like is some bot or script that's applying series and
> > publishing git branches with a messageid to git branch tool. 0-day is
> > doing this now. Basically, the opposite direction as others have
> > mentioned.
> It exists: it is called patchew and we are using it in QEMU and in Xen
> Project (
> It takes patch series off of a mailing list and commits them to a branch
> to trigger a CI-loop run. It is also able to send back a "passed" or
> "failed" email to the mailing list. It is great!

Yes, I've seen that. To me, that's really just a patchwork
alternative, and standing up a web server is not what I want. Now
maybe if someone else does and I can fetch what I need then it would
work. Otherwise, it's just another project with patch applying code
that can't be used on its own. But I doubt the patch applying would do
what's needed for Linux. According to documentation, it says it can
'Apply the patch series on top of git master'. My CI already does
that. I need apply to this git tree containing all these subsystem
trees (i.e. linux-next) and find the right base yourself. Note that
applying to linux-next itself is wrong as that's not a tree any
maintainer can apply patches to.

At the end of the day, I just want to do:

git fetch agitserver $(msgid2branch $msgid)


b4 am -o $msgid | a-smart-git-am-that-finds-the-right-commit-base


[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux