PATCH: LISTVIEW_GetItemT() and LISTVIEW_InsertItemT() read and write too much memory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The LISTVIEW_GetItemT() and LISTVIEW_InsertItemT() functions
read and write too much memory at *lpLPVItem. This is because of
size of the structure was increased - code compiled with older headers
(eg MSVC6) will still be using the smaller structures.

Reading too much is _fairly_ safe - it just makes valgrind shout. Writing
too much tends to trash the stack etc.

The attached patch checks the mask flags in the structure to determine
how much memory to read/write.


Seeya,
 Adam
--
Real Programmers don't comment their code. If it was hard to write,
it should be hard to read, and even harder to modify.
These are all my own opinions.

Attachment: listview.patch
Description: Binary data


[Index of Archives]     [Gimp for Windows]     [Red Hat]     [Samba]     [Yosemite Camping]     [Graphics Cards]     [Wine Home]

  Powered by Linux