Hi All, yeah, looks like there's a bit of confusion between RTS_CONTROL_ENABLE and RTS_CONTROL_HANDSHAKE in dlls/kernel/comm.c RTS_CONTROL_ENABLE does not mean we should use flow control, it means we should turn on RTS and leave it on. Similarly with DTR_CONTROL_ENABLE. Man, what confusing names. Is the (untested) patch attached helpful? Looks like there will be more issues with this... Mike >> perhaps the RTS_CONTROL_ENABLE should be RTS_CONTROL_HANDSHAKE? >> >> This would explain why in this case crtcts flowcontrol gets enabled on >> a 3 wire serial link. >> >> Rein. >> >I think if winbase.h is right, you are right and the code has been wrong >for a long time. The same error is all over the code. GetCommState >sets RTS_CONTROL_ENABLE if the termios from tcgetattr() has CRTSCTS. >Probably that should be RTS_CONTROL_HANDSHAKE? And where does >RTS_CONTROL_ENABLE come from? I guess it should be on by default? > >Lawson ------------------------------------------ mailto:Mike_McCormack@start.com.au ph +82 16 430 0425 __________________________________________________________________ Get your free Australian email account at http://www.Looksmart.com.au
Attachment:
handshake.diff
Description: Binary data
