Alex Zeffertt wrote: > Frederik Deweerdt wrote: > IMHO, raw sockets *should* always tag, rather than tag or not tag > depending on whether the > frame is already tagged. It just seems more logical and consistent. If a program is clever enough that it thinks it can send raw packets, I think it can send vlan tags too. But, we have to be able to remain backwards compat allowing sending raw ether frames to a vlan and have the vlan encapsulate. However, I don't think we have to allow sending a vlan frame to a vlan device and have it double-encapsulate. Perhaps the check could be: if non-framed or dev->vid != skb->vid then (re)encapsulate else send-as-is fi I think that will work in all currently supported cases, except where user-space sends a frame for a different VID to a VLAN. I believe bridging could do this currently, so we would have to fix bridging somehow. There would need to be a global config, either run-time or compile time, that would make the behaviour act like it does currently in case we need to work around any user-space or other kernel module issues. Ben > > Ciao, > > Alex > _______________________________________________ > Vlan mailing list > Vlan@xxxxxxxxxxxxxxx > http://www.candelatech.com/mailman/listinfo/vlan > -- Ben Greear <greearb@xxxxxxxxxxxxxxx> Candela Technologies Inc http://www.candelatech.com
