On 6/21/21 12:31 PM, Michal Privoznik wrote: > There are two domain XML knobs specific to NVDIMMs that > virt-install doesn't allow to set: <pmem/> and <alignsize/>. > Implement them. > > Closes: https://github.com/virt-manager/virt-manager/issues/267 > Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx> > --- > > v2 of: > > https://listman.redhat.com/archives/virt-tools-list/2021-June/msg00023.html > > diff to v1: > - Added discard for DIMMs > - Added target.readonly for NVDIMMs > > tests/data/cli/compare/virt-install-singleton-config-3.xml | 5 ++++- > tests/test_cli.py | 4 ++-- > virtinst/cli.py | 5 +++++ > virtinst/devices/memory.py | 4 ++++ > 4 files changed, 15 insertions(+), 3 deletions(-) Thanks, pushed now - Cole
