Re: [virt-manager][PATCH v2] virtinst: Support missing NVDIMM knobs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 21, 2021 at 06:31:49PM +0200, Michal Privoznik wrote:
> There are two domain XML knobs specific to NVDIMMs that
> virt-install doesn't allow to set: <pmem/> and <alignsize/>.
> Implement them.
> 
> Closes: https://github.com/virt-manager/virt-manager/issues/267
> Signed-off-by: Michal Privoznik <mprivozn@xxxxxxxxxx>
> ---
> 
> v2 of:
> 
> https://listman.redhat.com/archives/virt-tools-list/2021-June/msg00023.html
> 
> diff to v1:
> - Added discard for DIMMs
> - Added target.readonly for NVDIMMs

LGTM:
Reviewed-by: Erik Skultety <eskultet@redhat>




[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux