On 8/13/20 12:21 AM, Huacai Chen wrote: > Hi, Cole, > > On Thu, Aug 13, 2020 at 2:07 AM Cole Robinson <crobinso@xxxxxxxxxx> wrote: >> >> On 8/6/20 1:44 AM, Huacai Chen wrote: >>> Hi, Daniel, >>> >>> On Wed, Aug 5, 2020 at 10:57 PM Daniel P. Berrangé <berrange@xxxxxxxxxx> wrote: >>>> >>>> On Wed, Aug 05, 2020 at 10:42:22AM -0400, Cole Robinson wrote: >>>>> On 8/5/20 4:32 AM, Pavel Hrdina wrote: >>>>>> On Wed, Aug 05, 2020 at 12:44:24PM +0800, Huacai Chen wrote: >>>>>>> Hi, Pavel, >>>>>>> >>>>>>> On Mon, Aug 3, 2020 at 8:06 PM Pavel Hrdina <phrdina@xxxxxxxxxx> wrote: >>>>>>>> >>>>>>>> On Mon, Aug 03, 2020 at 04:45:03PM +0800, Huacai Chen wrote: >>>>>>>>> There is no "Error" in "Refresh snapshot list" and "Restoring virtual >>>>>>>>> machine memory from disk", so remove "出错" in the Chinese translations. >>>>>>>>> >>>>>>>>> Signed-off-by: Huacai Chen <chenhc@xxxxxxxxxx> >>>>>>>>> --- >>>>>>>>> po/zh_CN.po | 5 ++--- >>>>>>>>> 1 file changed, 2 insertions(+), 3 deletions(-) >>>>>>>> >>>>>>>> Hi, thank you for your contribution to virt-manager. The translation >>>>>>>> changes are not pushed directly to git repository. We use weblate >>>>>>>> service hosted by fedora where you should make the changes: >>>>>>>> >>>>>>>> https://translate.fedoraproject.org/projects/virt-manager/ >>>>>>> I have registered, and my user-name is chenhuacai. It seems that I >>>>>>> should be a member of cvsl10n, I have joined but it needs to be >>>>>>> approved. Could you please help me? >>>>>> >>>>> >>>>> Please keep us informed if you get approved or hit any more roadblocks. >>>>> Weblate is new for us so I'm not entirely certain what the process is here >>>>> >>>>>> I don't have the permissions to approve it but if you follow this guide >>>>>> you should be able to get approved https://fedoraproject.org/wiki/L10N/Guide >>>>>> >>>>> >>>>> FWIW Pavel I added you as a virt-manager weblate admin now >>>> >>>> IMHO, in this kind of case it is better if one of the project maintainers >>>> just copy the change into Weblate, instead of expecting the patch submitter >>>> to create themselves an account. The account creation is only a good use >>>> of time if the contributor intends to become a long term translator. >>> For me, it is OK that maintainers do it in Weblate, but it is also OK >>> to approve my account. If approved, I think I can do more translation >>> in future. >>> >> >> I looked in the weblate UI under zh_CN and I think I see changes from >> you. Were you approved? If so what did the notification look like? I'm >> trying to determine if this is something I have control over, or is the >> responsibility of another team (I know other translation systems have >> the notion of language teams who have to approve people, I'm wondering >> if that's the case here) > I modified zh_CN in weblate (only one place in the patch, the other > place cannot be found in weblate), but I haven't been approved. > Hmm I guess I don't know what the approval is all about then. The github PR that weblate opened does have your changes: https://github.com/virt-manager/virt-manager/pull/131 So I think everything worked as expected Thanks, Cole
