In this version, I address comments from Christophe in patch number 2 "Fetch ISO names using GTask API", basically adding more error handling. In "Add accessors for current iso and iso list" I changed the return type from char * to gchar * and changed users of the code accordingly. Finally, I split the code in "Make ovirt-foreign-menu a property" and moved that one patch before the "Introduce ISO List dialog". Regards, Eduardo. Eduardo Lima (Etrunko) (9): ovirt-foreign-menu: Set new ISO name using GTask API ovirt-foreign-menu: Fetch ISO names using GTask API remote-viewer: Make ovirt-foreign-menu a property Introduce ISO List dialog ovirt-foreign-menu: Add accessors for current iso and iso list iso-dialog: Implement functionality provided by oVirt foreign menu iso-dialog: Use header bar for buttons Run iso-dialog when 'Change CD' menu is activated ovirt-foreign-menu: Remove GtkMenu related functions configure.ac | 4 +- po/POTFILES.in | 2 + src/Makefile.am | 3 + src/ovirt-foreign-menu.c | 307 +++++++++++++------------- src/ovirt-foreign-menu.h | 21 +- src/remote-viewer-iso-list-dialog.c | 340 +++++++++++++++++++++++++++++ src/remote-viewer-iso-list-dialog.h | 58 +++++ src/remote-viewer.c | 87 ++++---- src/resources/ui/remote-viewer-iso-list.ui | 135 ++++++++++++ src/resources/ui/virt-viewer.ui | 19 +- src/resources/virt-viewer.gresource.xml | 1 + src/virt-viewer-window.c | 37 ++++ 12 files changed, 799 insertions(+), 215 deletions(-) create mode 100644 src/remote-viewer-iso-list-dialog.c create mode 100644 src/remote-viewer-iso-list-dialog.h create mode 100644 src/resources/ui/remote-viewer-iso-list.ui -- 2.9.3 _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
