Re: [PATCH virt-viewer 01/10] remote-viewer: Extend #ifdef HAVE_OVIRT block

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 17/01/17 13:51, Christophe Fergeau wrote:
> Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>

Pushed, thanks
> 
> On Fri, Jan 13, 2017 at 07:11:03PM -0200, Eduardo Lima (Etrunko) wrote:
>> The #endif is closing a #ifdef HAVE_OVIRT block, while another one is
>> opened right next, so there is no need to have those lines. Also, due to
>> the large amount of source code in between, add a small comment on the
>> last #endif to identify what it refers to.
>>
>> Signed-off-by: Eduardo Lima (Etrunko) <etrunko@xxxxxxxxxx>
>> ---
>>  src/remote-viewer.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/src/remote-viewer.c b/src/remote-viewer.c
>> index 6d29bf2..13c6e7c 100644
>> --- a/src/remote-viewer.c
>> +++ b/src/remote-viewer.c
>> @@ -1005,9 +1005,6 @@ error:
>>      return success;
>>  }
>>  
>> -#endif
>> -
>> -#ifdef HAVE_OVIRT
>>  static OvirtVm *
>>  choose_vm(GtkWindow *main_window,
>>            char **vm_name,
>> @@ -1047,7 +1044,7 @@ choose_vm(GtkWindow *main_window,
>>  
>>      return vm;
>>  }
>> -#endif
>> +#endif /* HAVE_OVIRT */
>>  
>>  static void
>>  remote_viewer_recent_add(gchar *uri, const gchar *mime_type)
>> -- 
>> 2.9.3
>>
>> _______________________________________________
>> virt-tools-list mailing list
>> virt-tools-list@xxxxxxxxxx
>> https://www.redhat.com/mailman/listinfo/virt-tools-list


-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko@xxxxxxxxxx

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list



[Index of Archives]     [Linux Virtualization]     [KVM Development]     [CentOS Virtualization]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux