On Sat, Dec 17, 2016 at 05:50:07PM +0100, Fabiano Fidêncio wrote: > From: Fabiano Fidêncio <fabiano@xxxxxxxxxxxx> > > So, this patch series has been waiting for a long time to be upstreamed > and during this week there was some conversations on #spice about getting > it reviewed (even though I had already mentioned a few times it's been > blocked by the changes not yet merged in the foreign-menu, which will > become an item instead under preferences instead of the menu it is > nowadays). > > Now I've taken the bullet and rebased the series on top of a branch[0] > which contains the latest work (in progress) done in the foreign menu. > Or also cloneed directly from my github[1]. > > For those who will be testing and reviewing, please, apply thos patches > on top of [0]. > > I was able to do some tests using RHEVM and foreign-menu icon > "showability" works as expected. > > An important note here is that while I'm the person sending the patches > the person who ended up writing the most part of the code is Sagar > Ghuge, so, big thanks to him! > > I've done a few rounds of reviews privately with Sagar and IMO the > patches, if not in the best shape, are quite okay. > > Hopefully we will be able to see it merged soon :-) IMHO the result needs more work for non-GNOME desktop environments. If I run it on non-GNOME, then I get the window manager's title bar followed by the virt-viewer titlebar, duplicating the min/max/close buttons and the window title. This wastes screen real estate and looks pretty ugly, so I think we need to do better than that for non-GNOME. ie, keep the original menu bar as-is for non-GNOME desktops, and don't display the new fat header bar. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :| _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
