From: Fabiano Fidêncio <fabiano@xxxxxxxxxxxx> So, this patch series has been waiting for a long time to be upstreamed and during this week there was some conversations on #spice about getting it reviewed (even though I had already mentioned a few times it's been blocked by the changes not yet merged in the foreign-menu, which will become an item instead under preferences instead of the menu it is nowadays). Now I've taken the bullet and rebased the series on top of a branch[0] which contains the latest work (in progress) done in the foreign menu. Or also cloneed directly from my github[1]. For those who will be testing and reviewing, please, apply thos patches on top of [0]. I was able to do some tests using RHEVM and foreign-menu icon "showability" works as expected. An important note here is that while I'm the person sending the patches the person who ended up writing the most part of the code is Sagar Ghuge, so, big thanks to him! I've done a few rounds of reviews privately with Sagar and IMO the patches, if not in the best shape, are quite okay. Hopefully we will be able to see it merged soon :-) Best Regards, [0]: https://cgit.freedesktop.org/~teuf/virt-viewer/log/?h=ovirt [1]: https://gitlab.com/fidencio/virt-viewer/commits/wip/headerbar Fabiano Fidêncio (2): app: Set the resource base path headerbar: Add ability to "Change CD" in fullscreen Sagar Ghuge (3): app: Use app-menu window: Replace menu bar with headerbar window: Replace toolbar with headerbar (fullscreen) configure.ac | 4 +- icons/24x24/Makefile.am | 4 - icons/24x24/virt-viewer-usb.png | Bin 1063 -> 0 bytes icons/24x24/virt-viewer-usb.svg | 204 ------ po/POTFILES.in | 1 + src/Makefile.am | 1 + src/remote-viewer.c | 12 +- src/resources/gtk/menus.ui | 25 + src/resources/ui/virt-viewer.ui | 526 ++++++------- src/resources/virt-viewer.gresource.xml | 2 +- src/virt-viewer-app.c | 264 ++++--- src/virt-viewer-app.h | 1 - src/virt-viewer-display-spice.c | 14 +- src/virt-viewer-display-vnc.c | 14 +- src/virt-viewer-file.c | 26 +- src/virt-viewer-timed-revealer.c | 2 +- src/virt-viewer-window.c | 1215 ++++++++++++++----------------- src/virt-viewer-window.h | 6 +- 18 files changed, 1088 insertions(+), 1233 deletions(-) delete mode 100644 icons/24x24/virt-viewer-usb.png delete mode 100644 icons/24x24/virt-viewer-usb.svg create mode 100644 src/resources/gtk/menus.ui -- 2.9.3 _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
