On Wed, Oct 05, 2016 at 11:29:14AM +0200, Pavel Grunt wrote: > virt-viewer uses spice-glib api, configure should check > for the required version > > Related: > https://bugzilla.redhat.com/show_bug.cgi?id=1375429 > --- > configure.ac | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/configure.ac b/configure.ac > index 7c437a3..89e7641 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -158,11 +158,13 @@ AC_ARG_WITH([spice-gtk], > > AS_IF([test "x$with_spice_gtk" != "xno" && test "x$with_spice_gtk" != "xyes"], > [PKG_CHECK_EXISTS([spice-client-gtk-3.0 >= $SPICE_GTK_REQUIRED > + spice-client-glib-2.0 >= $SPICE_GTK_REQUIRED > spice-controller spice-protocol >= $SPICE_PROTOCOL_REQUIRED], > [with_spice_gtk=yes], [with_spice_gtk=no])]) > > AS_IF([test "x$with_spice_gtk" = "xyes"], > - [PKG_CHECK_MODULES(SPICE_GTK, [spice-client-gtk-3.0 >= $SPICE_GTK_REQUIRED])] > + [PKG_CHECK_MODULES(SPICE_GTK, [spice-client-gtk-3.0 >= $SPICE_GTK_REQUIRED > + spice-client-glib-2.0 >= $SPICE_GTK_REQUIRED])] spice-client-gtk-3.0 requires spice-client-glib-2.0 so we would get a check transitively (and spice-client-gtk-3.0.pc could get an additional check to make sure the version is high enough). Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx> Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
