On Wed, Dec 16, 2015 at 06:44:44PM -0200, Eduardo Lima (Etrunko) wrote:
> Hi Jonathon,
>
> It seems I got a bit lost with the all comments on the previous series
> and some of them became were not addressed. Once again, thanks for the
> review. My comments follow inline. I am working on the new version of
> this series.
>
> On 12/14/2015 08:46 PM, Jonathon Jongsma wrote:
> >> @@ -238,11 +275,11 @@ remote_viewer_init(RemoteViewer *self)
> >> }
> >>
> >> RemoteViewer *
> >> -remote_viewer_new(const gchar *uri)
> >> +remote_viewer_new(void)
> >> {
> >> return g_object_new(REMOTE_VIEWER_TYPE,
> >> - "guri", uri,
> >> - "open-recent-dialog", uri == NULL,
> >> + "application-id", "org.fedorahosted.remote-viewer",
> >
> > Still using org.fedorahosted. Does anybody else have an opinion on this? I
> >
>
> I think we could be using "virt-manager" instead of fedorahosted. But it
> is simple enough to change it.
Yes, we host the application on virt-manager.org, so we should be using
org.virt-manager.remote-viewer
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
