In this second round, I addresed most of the concerns that were raised in v1, especially keeping compatibility with glib 2.38. I tried to keep patches as self-contained as possible, in either case of having this functionatily fully or partially merged. The first two patches seem to be ready for merge, and do not interfere in the rest of the series. The main patch is the third one, which does all the porting. I chose to update glib requirement to 2.40 here and only downgrade it to 2.38 after I had all the compatibility layer working. This way I avoided having a broken patch in the middle of the tree, which could cause troubles in future git bisects. The next two are the ones which backport functions only available in glib 2.40 onwards, with no changes to the code. These are contained in #ifndef GLIB_VERSION_2_40 blocks, also to maintain the code building. Last couple are the adaptations of the glib code to build outside of the tree and integrate with virt-viewer. Eduardo Lima (Etrunko) (6): Minor code cleanups Port to GtkApplication API's Backport GApplication code from glib 2.40 Backport GVariantDict code from glib 2.40 Adapt glib code to build out of the tree Make GApplication port compatible with older glib Fabiano Fidêncio (1): Drop support to gtk2 configure.ac | 43 +--- src/remote-viewer-main.c | 122 +-------- src/remote-viewer.c | 174 ++++++++++--- src/remote-viewer.h | 3 +- src/view/autoDrawer.c | 10 - src/view/ovBox.c | 45 ---- src/virt-glib-compat.c | 640 ++++++++++++++++++++++++++++++++++++++++++++++ src/virt-glib-compat.h | 42 +++ src/virt-gtk-compat.h | 12 - src/virt-viewer-app.c | 238 ++++++++++------- src/virt-viewer-app.h | 18 +- src/virt-viewer-display.c | 96 ------- src/virt-viewer-main.c | 102 +------- src/virt-viewer-window.c | 10 - src/virt-viewer.c | 126 +++++++-- src/virt-viewer.h | 8 +- src/virt-viewer.xml | 2 +- virt-viewer.spec.in | 23 -- 18 files changed, 1090 insertions(+), 624 deletions(-) -- 2.5.0 _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
