On Mon, Nov 30, 2015 at 4:39 PM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > ACK I didn't push this one because it's a bit critical IMHO and I will explain why :-) A few months ago I dropped gtk2 support from the Windows builds in order to avoid maintenance of a code that is not being used as, for Windows builds, we have been using gtk3 since 2.0. The only problem with the gtk3 approach is that Windows XP support has been dropped (I found it out after posting this patch, while debugging a non-related crash). So, if we go for a gtk3 build we automatically are dropping Windows XP support as well. So, I'd like to hear from everyone (also including Daniel) if I should revert those patches removing gtk2 support for windows and with that have a last release with Windows XP support or if we are okay dropping Windows XP support. > > On Mon, Nov 30, 2015 at 12:41:25PM +0100, Fabiano Fidêncio wrote: >> 0a7fa73f is the commit that dropped support for gtk2 for the nsis >> installer. >> 03c014cb is the commit that dropped support for gtk2 for the msi >> installer. >> --- >> autobuild.sh | 36 ++---------------------------------- >> 1 file changed, 2 insertions(+), 34 deletions(-) >> >> diff --git a/autobuild.sh b/autobuild.sh >> index 164bdaf..f63c635 100755 >> --- a/autobuild.sh >> +++ b/autobuild.sh >> @@ -80,26 +80,10 @@ if [ -x /usr/bin/i686-w64-mingw32-gcc ]; then >> --build=$(uname -m)-w64-linux \ >> --host=i686-w64-mingw32 \ >> --prefix="$AUTOBUILD_INSTALL_ROOT/i686-w64-mingw32/sys-root/mingw" \ >> - --with-gtk=2.0 >> + --with-gtk=3.0 >> >> make >> make install >> - >> - # Test GTK3 build too if available >> - PKG_CONFIG_LIBDIR=/usr/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig pkg-config gtk+-3.0 1>/dev/null 2>&1 >> - if test $? = 0 ; then >> - make distclean >> - PKG_CONFIG_LIBDIR="/usr/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig:/usr/i686-w64-mingw32/sys-root/mingw/share/pkgconfig" \ >> - PKG_CONFIG_PATH="$AUTOBUILD_INSTALL_ROOT/i686-w64-mingw32/sys-root/mingw/lib/pkgconfig" \ >> - CC="i686-w64-mingw32-gcc" \ >> - ../configure --prefix=$AUTOBUILD_INSTALL_ROOT \ >> - --build=$(uname -m)-w64-linux \ >> - --host=i686-w64-mingw32 \ >> - --prefix="$AUTOBUILD_INSTALL_ROOT/i686-w64-mingw32/sys-root/mingw" \ >> - --with-gtk=3.0 >> - make >> - make install >> - fi >> fi >> >> >> @@ -113,26 +97,10 @@ if [ -x /usr/bin/x86_64-w64-mingw32-gcc ]; then >> --build=$(uname -m)-w64-linux \ >> --host=x86_64-w64-mingw32 \ >> --prefix="$AUTOBUILD_INSTALL_ROOT/x86_64-w64-mingw32/sys-root/mingw" \ >> - --with-gtk=2.0 >> + --with-gtk=3.0 >> >> make >> make install >> - >> - # Test GTK3 build too if available >> - PKG_CONFIG_LIBDIR=/usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig pkg-config gtk+-3.0 1>/dev/null 2>&1 >> - if test $? = 0 ; then >> - make distclean >> - PKG_CONFIG_LIBDIR="/usr/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig:/usr/x86_64-w64-mingw32/sys-root/mingw/share/pkgconfig" \ >> - PKG_CONFIG_PATH="$AUTOBUILD_INSTALL_ROOT/x86_64-w64-mingw32/sys-root/mingw/lib/pkgconfig" \ >> - CC="x86_64-w64-mingw32-gcc" \ >> - ../configure --prefix=$AUTOBUILD_INSTALL_ROOT \ >> - --build=$(uname -m)-w64-linux \ >> - --host=x86_64-w64-mingw32 \ >> - --prefix="$AUTOBUILD_INSTALL_ROOT/x86_64-w64-mingw32/sys-root/mingw" \ >> - --with-gtk=3.0 >> - make >> - make install >> - fi >> fi >> >> if test -x /usr/bin/i686-w64-mingw32-gcc && test -x /usr/bin/x86_64-w64-mingw32-gcc ; then >> -- >> 2.5.0 >> >> _______________________________________________ >> virt-tools-list mailing list >> virt-tools-list@xxxxxxxxxx >> https://www.redhat.com/mailman/listinfo/virt-tools-list Best Regards, -- Fabiano Fidêncio _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
