On 08/11/2015 01:12 PM, Anish Mathew wrote: > Cole, > > I am adding a PCIe accelerator with CPUs and a NIC. > > Is there any plan to change the procedure for users to add virt-manager UI > support for a device without code change? No, that won't change. Extending the app will always require code change... I can't imagine how we would even make it work without changing code. > My concern is that as new libvirt source changes are released, I have to > maintain one or more patches. > You won't need to maintain patches if you get them upstream... - Cole > > > On 8/9/2015 11:23 AM, Cole Robinson wrote: >> On 08/07/2015 11:51 AM, Anish Mathew wrote: >>> Hello, >>> >>> I am adding a custom PCI device to virt-manager. I have edited >>> virt-manager source (addhardware.py ,__init__.py ,addhardware.ui, device.py) >>> so the custom device will appear in "Add Hardware" window of virt-manager. >>> Now it looks like I have to edit libvirt qemu capabilities >>> (qemu_capabilities.c libvirt.c) >>> to support the device. Is this the right procedure for adding custom devices? >>> >>> I was expecting to edit an XML file or other config file rather than source >>> code. >>> Is there any plan to change this procedure for adding custom devices? >> What is the device you are trying to add? >> >> If you are just trying to attach a device to a libvirt VM, use 'sudo virsh >> edit $vmname' and add your XML >> >> But if you are trying to extend virt-manager to have UI support for a device >> type that it does not already support, you will need to edit code like you say. >> >> What device are you trying to add? >> >> - Cole >> > > > --- > This email has been checked for viruses by Avast antivirus software. > http://www.avast.com > _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
