On 12/05/2014 10:28 AM, Cedric Bosdonnat wrote:
Hi Cole,
On Fri, 2014-12-05 at 09:49 -0500, Cole Robinson wrote:
RH distros use /usr/libexec/libvirt_lxc, so we'd want to add that as well. I
can fix that when applying though
Oh, I forgot about that... but yes and /usr/lib/libvirt_lxc as well for
32 bits too.
Are you adding this patch for completeness, or because it's something that's
needed/wanted in suse?
It's something I added to get a smoother experience for our lxc-only
users.
Personally I don't think this is a good idea though. While virt-manager can
drive LXC, it's very different from qemu/xen particularly when creating VMs.
I'm afraid a clueless user would run virt-manager for the first time,
inadvertently end up connected to lxc, try to create a VM, and be confused
like 'wheres the option for CDROM install? etc.
In practice I don't know how likely that is on Fedora though, not sure why a
random user would end up with libvirt-lxc installed but not qemu unless it was
done deliberately.
It's pretty easy to install libvirt-lxc on SUSE distros without qemu...
It's easy on fedora too, but that wasn't my point. My point was about whether
it's a situation a clueless user could stumble into. On Fedora at least I
can't think of a scenario outside a user explicitly installing lxc and not
qemu, and if they are doing that, they can handle an extra step in virt-manager.
So I'd say if this is just a patch for completeness, it shouldn't go in. But
if you guys are going to carry it regardless, then we can apply this, and I
can add a 'python setup.py configure' option like --default-hypervisors to
limit what virt-manager will connect to by default. That's probably useful to
do anyways for freebsd bhyve guys at least
We're going to keep that patch around in our repos if it doesn't get it
here...
Okay, I've pushed it now, thanks. I'll add the configure option before the
next release and message back here when it's available
- Cole
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
