On 12/10/2014 07:52 AM, Giuseppe Scrivano wrote:
Cole Robinson <crobinso@xxxxxxxxxx> writes:
On 12/10/2014 05:29 AM, Giuseppe Scrivano wrote:
Problem introduced by commit 1662f75e07e8bfb46a552c686e2db3e4368786b6
Signed-off-by: Giuseppe Scrivano <gscrivan@xxxxxxxxxx>
---
virtManager/domain.py | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/virtManager/domain.py b/virtManager/domain.py
index 2d4afcb..ad9f8a6 100644
--- a/virtManager/domain.py
+++ b/virtManager/domain.py
@@ -496,7 +496,10 @@ class vmmDomain(vmmLibvirtObject):
for disk in self.get_disk_devices(refresh_if_nec=False):
if disk.read_only:
continue
- if not disk.path:
+ try:
+ if not disk.path:
+ continue
+ except libvirt.libvirtError:
continue
if disk.driver_type == "qcow2":
seen_qcow2 = True
Thanks for the report. We might want to handle this lower in the code
since this could cause issues elsewhere as well. This is just with a
type=volume disk where the volume doesn't exist? I'll poke at it.
now that I look more carefully at it, the problem is caused by this:
<disk type='volume' device='disk'>
<driver name='qemu'/>
<source pool='default' volume='afile'/>
<target dev='vda' bus='virtio'/>
</disk>
Regards,
Giuseppe
I added an example in the testdriver and fixed the root issue upstream
Thanks,
Cole
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
