Re: [PATCH] Do not show duplicated menu items

["Daniel P. Berrange" <berrange@xxxxxxxxxx>]

On Wed, Sep 10, 2014 at 04:30:07PM +0200, Fabiano Fidêncio wrote:
> When the support to use numpad accelerators for zoom-{in,out,reset}
> was added (3a168815), by mistake, we have added duplicated buttons
> in View -> Zoom.
> ---
>  src/virt-viewer.xml | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/virt-viewer.xml b/src/virt-viewer.xml
> index 760550e..6f2eebb 100644
> --- a/src/virt-viewer.xml
> +++ b/src/virt-viewer.xml
> @@ -141,7 +141,7 @@
>                                <object class="GtkImageMenuItem" id="menu-view-kp-zoom-in">
>                                  <property name="accel_path">&lt;virt-viewer&gt;/view/kp-zoom-in</property>
>                                  <property name="label">gtk-zoom-in</property>
> -                                <property name="visible">True</property>
> +                                <property name="visible">False</property>
>                                  <property name="can_focus">False</property>
>                                  <property name="use_action_appearance">False</property>
>                                  <property name="use_underline">True</property>
> @@ -165,7 +165,7 @@
>                                <object class="GtkImageMenuItem" id="menu-view-kp-zoom-out">
>                                  <property name="accel_path">&lt;virt-viewer&gt;/view/kp-zoom-out</property>
>                                  <property name="label">gtk-zoom-out</property>
> -                                <property name="visible">True</property>
> +                                <property name="visible">False</property>
>                                  <property name="can_focus">False</property>
>                                  <property name="use_action_appearance">False</property>
>                                  <property name="use_underline">True</property>
> @@ -195,7 +195,7 @@
>                                <object class="GtkImageMenuItem" id="menu-view-kp-zoom-reset">
>                                  <property name="accel_path">&lt;virt-viewer&gt;/view/kp-zoom-reset</property>
>                                  <property name="label">gtk-zoom-100</property>
> -                                <property name="visible">True</property>
> +                                <property name="visible">False</property>
>                                  <property name="can_focus">False</property>
>                                  <property name="use_action_appearance">False</property>
>                                  <property name="use_underline">True</property>

Err, we should delete the duplicate menu objects entirely rather than
just making them invisible

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list