On 01/28/2014 08:21 AM, Cole Robinson wrote: >> f919cf691735535dedc66a2cae244350ebb6c5e5 >> >> virsh # attach-disk aa 1.img sdd --shareable --mode=readonly --print-xml >> error: option --mode already seen >> >> If throwing errors is not acceptable, do we have some better metod to avoid this? >> > > That just looks like general virsh 'this option was specified twice on the > command line' warning. > > The XML allows setting both shareable and readonly simultaneously, so I don't > see why virt-manager should disallow it. Even if the XML rejected that > combination, there's virtually no benefit to explicitly check for it in > virt-manager: we would just let libvirt throw the error. But technically the mode is a tristate - you're either readonly, or you're shareable, or you're read-write. The fact that the XML allows <shareable/> and <readonly/> at the same time is somewhat of a bug (but we probably can't change it for fear of back-compat - I think it is treated as though just <readonly/> were specified). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
