At 2014-01-28 22:21:26,"Cole Robinson" <crobinso@xxxxxxxxxx> wrote:
>On 01/28/2014 02:09 AM, Chen Hanxiao wrote: >> From: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> >> >> Currently we could config disk with readonly and >> shareable at the same time, which is meaningless. >> virsh had already discouraged users doing this. >> This patch will disable users to config both >> readonly and shareable at the same time by UI. >> > >How does 'virsh' complain? If libvirt throws an error about this, I'd rather >just let it complain and show that error to the user, than reproduce their >error check, since this is a fairly minor corner case. >virsh could not do this since commit:f919cf691735535dedc66a2cae244350ebb6c5e5virsh # attach-disk aa 1.img sdd --shareable --mode=readonly --print-xml error: option --mode already seenIf throwing errors is not acceptable, do we have some better metod to avoid this?Thanks-Chen
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
