On Fri, Jan 17, 2014 at 11:03:46AM -0500, Jonathon Jongsma wrote: > Hey, > > ----- Original Message ----- > > From: "Christophe Fergeau" <cfergeau@xxxxxxxxxx> > > To: "Jonathon Jongsma" <jjongsma@xxxxxxxxxx> > > Cc: virt-tools-list@xxxxxxxxxx > > Sent: Friday, January 17, 2014 7:43:44 AM > > Subject: Re: [PATCH virt-viewer] Load ui files first from installed location > > > > Hey, > > > > On Thu, Jan 16, 2014 at 12:36:15PM -0600, Jonathon Jongsma wrote: > > > virt_viewer_util_load_ui() looks first in the current directory, and then > > > looks > > > in the system data dirs for a ui file to load, but if you install > > > virt-viewer in > > > a different prefix, it will load the system UI file rather than the one > > > from the > > > install prefix. Try to load the ui file from pkgdatadir first. > > > > I'm not sure we should try to use g_get_system_data_dirs() at all as I > > generally don't expect having the application look in /usr/share when I set > > $prefix. > > > > Christophe > > > > > it looks like the system data dirs stuff was added in commit 1002a220 to > fix a problem on windows. I'm not sure of all the details since the > changelog just says "Load UI file correctly, to fix Windows support". > (side note: it would be nice if the commit logs had more details about > what is being fixed, and why). So, I guess we should probably leave that > in for the windows port, though it will never be used on linux. Ah, right, in Windows, I think this automatically looks up for data files in ../share relative to the location of the binary being run, so yeah, this needs to be kept. ACK to the initial patch. Christophe
Attachment:
pgpeLXqWqRWTj.pgp
Description: PGP signature
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
