On 11/20/2013 04:22 AM, Chen Hanxiao wrote: > > >> -----Original Message----- >> From: Cole Robinson [mailto:crobinso@xxxxxxxxxx] >> Sent: Tuesday, November 19, 2013 9:23 PM >> To: Giuseppe Scrivano; Chen Hanxiao >> Cc: virt-tools-list@xxxxxxxxxx >> Subject: Re: [virt-tool-list][PATCH]virt-manager: use > host CPU >> configuration when creating new VM >> >> On 11/19/2013 07:52 AM, Giuseppe Scrivano wrote: >>> Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> writes: >>> >>>> From: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> >>>> >>>> This patch will use host CPU configuration automatically >>>> when creating new VM. >>> >>> on what version of virt-manager is your patch based? I tried to apply >>> it to the current git master branch[1] but I get a conflict. >>> >>> In addition, I am not sure what is the impact of such a change, what are >>> for example the downsides for a migration if we default to a more >>> restrictive CPU configuration. >>> >> >> Indeed, just doing this unconditionally is not an option. >> >> I will be working on this within the next few weeks. My plan is to add an >> option 'Default CPU for New VMs' to the Preferences dialog. There will be > 3 >> options: > > How about add this on vmm-create.ui: tab Memory? No, the CPU choice is sufficiently complex and has many caveats that sticking it in the 'New VM' wizard is just going to cause more user confusion. And I don't forsee people wanting to enter a different value for each new VM, they likely want just one value used for all VMs, but that particular value may vary user to user. >> >> 1) hypervisor default (no <cpu> block) >> 2) copy just the detected CPU model (so pentium3, Opteron_G4, etc) > > use baselineCPU()? > >> 3) full <cpu> copy (so either what this patch suggests, or use host-model > > use copy_host_cpu()? > Basically, yes. - Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
