> -----Original Message----- > From: Giuseppe Scrivano [mailto:gscrivan@xxxxxxxxxx] > Sent: Tuesday, November 19, 2013 8:52 PM > To: Chen Hanxiao > Cc: virt-tools-list@xxxxxxxxxx > Subject: Re: [virt-tool-list][PATCH]virt-manager: use host CPU > configuration when creating new VM > > Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> writes: > > > From: Chen Hanxiao <chenhanxiao@xxxxxxxxxxxxxx> > > > > This patch will use host CPU configuration automatically > > when creating new VM. > > on what version of virt-manager is your patch based? I tried to apply > it to the current git master branch[1] but I get a conflict. > My virt-manager git is a little old. I'll try to update it to the latest > In addition, I am not sure what is the impact of such a change, what are > for example the downsides for a migration if we default to a more > restrictive CPU configuration. > libvirt may refuse to start the VM with a poorer CPU. And I think user will not be too surprise when they meet this scenario. Just clear the old config, and press the existed button 'Copy host CPU configuration' will give them better performance and more feature. We can doc this for users. > Regards, > Giuseppe > > 1) https://git.fedorahosted.org/cgit/virt-manager.git/log/ _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list