On Thu, Aug 15, 2013 at 4:36 PM, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote:
> On Mon, Jul 15, 2013 at 09:36:10PM +0200, Marc-André Lureau wrote:
>> ---
>> src/virt-viewer-app.c | 22 +++++++++++++++++++++-
>> 1 file changed, 21 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
>> index 794dddd..5456b8d 100644
>> --- a/src/virt-viewer-app.c
>> +++ b/src/virt-viewer-app.c
>> @@ -1235,6 +1235,26 @@ static void virt_viewer_app_usb_failed(VirtViewerSession *session G_GNUC_UNUSED,
>> }
>>
>> static void
>> +virt_viewer_app_set_kiosk(VirtViewerApp *self, gboolean enabled)
>> +{
>> + int i;
>> +
>> + self->priv->kiosk = enabled;
>> + virt_viewer_app_set_fullscreen(self, enabled);
>> +
>> + if (enabled) {
>> + for (i = 1; i < gdk_screen_get_n_monitors(gdk_screen_get_default()); i++) {
>> + if (virt_viewer_app_get_nth_window(self, i))
>> + continue;
>> +
>> + VirtViewerWindow *win = virt_viewer_app_window_new(self, i);
>> + virt_viewer_window_show(win);
>> + }
>> + }
>> +}
>
> What's going to happen here with VNC which only has one monitor, or with
> spice if they don't have the guest agent present to configure the guest
> to use all monitors. Will we just get full screen, but empty windows ?
Yes, it will have empty windows on extra monitors.
>
> It would be desirable if the commit message was more verbose about the
> behaviour of this change.
ok
--
Marc-André Lureau
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
