On Thu, Aug 15, 2013 at 06:40:39PM +0200, Marc-André Lureau wrote: > On Thu, Aug 15, 2013 at 4:38 PM, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote: > > On Mon, Jul 15, 2013 at 09:36:12PM +0200, Marc-André Lureau wrote: > > > > Again, a description of why we want this change in the commit message.... > > That was in the RFE, without further explanation. I don't know either. > I will need to ask reporter why. I guess it's mostly to lock a bit > more the system? I agree, I am not sure it's necessary here. > > >> --- > >> src/virt-viewer-app.c | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c > >> index a38841c..d5acd2c 100644 > >> --- a/src/virt-viewer-app.c > >> +++ b/src/virt-viewer-app.c > >> @@ -793,6 +793,10 @@ virt_viewer_app_create_session(VirtViewerApp *self, const gchar *type) > >> return -1; > >> } > >> > >> + > >> + if (priv->kiosk) > >> + virt_viewer_session_set_auto_usbredir(priv->session, FALSE); > > > > I'm not entirely sure it makes sense to unconditonally disable USB redir > > for kiosk modes. I think it could well be reasonable to allow a user to > > plug USB devices into the physical kiosk host and have them exposed to > > the guest. This might suggest the need for a cli arg to disable > > usb redir separately from kiosk mode. > > We have already --spice-disable-usbredir. I'll remove that patch. Agreed, that sounds like it should be sufficient for those who need the extra level of lockdown. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
