On 06/24/2013 06:11 AM, Guannan Ren wrote: > Add "Select USB devices to redirect" option in console viewer > Initialize and embed UsbDeviceWidget object from SpiceClientGtk into > a dialog to let use choose available USB devices for redirection. > Throw an error message if USB connection failed. A few suggestions. - If a VM isn't configured with spicevmc or a redir dev the USB redirection isn't going to work and we should disable that menu entry. virt-viewer already does this so you can steal the criteria from them. However I'd also like to give the menu entry a tooltip detailing everything we know that's missing so the user has a chance of figuring it out. - Drop the separator between 'screenshot' and the new entry USB menu entry. - I'd change the menu item text to 'Redirect USB device'. I don't think that's particularly clear, but we are kind of in a hard spot since we have two different methods of assigning USB devices, so something generic like 'Attach USB device' is non-specific. Thanks, Cole _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
