On 04/23/2013 01:56 PM, Guannan Ren wrote: > On 04/23/2013 07:37 PM, Martin Kletzander wrote: >> On 04/20/2013 10:09 PM, Cole Robinson wrote: >>> On 04/18/2013 03:47 AM, Guannan Ren wrote: >>>> v1 to v2: >>>> removed UPDATE_CPU flag checking >>>> renamed helper function name from reset() to clear_attrs() >>>> change the check box to be labeled 'Use host CPU model' >>>> remove the lightbulb icon, use tooltip instead >>>> reword the tooltip from Cole's >>>> remove the WARN image icon from UI >>>> >>>> Add a checkbox for 'host-model' mode and removed 'Copy host CPU >>>> configuration' >>>> button. >>>> >> Sorry for not catching this thread earlier, but IIUC, the 'host-model' >> doesn't make up for the button. XML is saved with 'host-model' then, >> right? >> >> Unfortunately, I can't see that easily right now as git virt-manager >> consistently crashes for me on all VMs and bare metal as well and I made >> that one of my priorities in order to speed up the bug hunt on it. >> > > Martin, I am using virt-manager git head now, it seems fine for me. > Is there anything wrong about 'host-model', I can't quite follow you > here. > > Guannan > I was just wondering if dropping the button isn't a bad idea, some guest OS might have problems when it is ran on different CPU, which is what might happen with host-model after destroy/start, but would be avoided with 'Copy host configuration'. I'm not saying 'host-model' is wrong, we definitely want the support for that. Hope that's more understandable, Martin _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
