On 04/20/2013 10:09 PM, Cole Robinson wrote: > On 04/18/2013 03:47 AM, Guannan Ren wrote: >> >> v1 to v2: >> removed UPDATE_CPU flag checking >> renamed helper function name from reset() to clear_attrs() >> change the check box to be labeled 'Use host CPU model' >> remove the lightbulb icon, use tooltip instead >> reword the tooltip from Cole's >> remove the WARN image icon from UI >> >> Add a checkbox for 'host-model' mode and removed 'Copy host CPU configuration' >> button. >> Sorry for not catching this thread earlier, but IIUC, the 'host-model' doesn't make up for the button. XML is saved with 'host-model' then, right? Unfortunately, I can't see that easily right now as git virt-manager consistently crashes for me on all VMs and bare metal as well and I made that one of my priorities in order to speed up the bug hunt on it. >> If the host-model is selected, disable the cpu model drop down and features list. >> But they still show what exact configuration the host-model is using after the >> vm is defined. >> >> For the old libvirt which doesn't support <cpu mode='host-model'/> virt-manager >> still copy cpu configs from caps XML to domain XML. >> >> Guannan Ren(3) >> [PATCH v2 1/3] check cpu host-model mode support >> [PATCH v2 2/3] cpu: add helper function to reset cpu related variables >> [PATCH v2 3/3] add a checkbox for cpu host-model mode, remove 'copy' >> >> ui/vmm-details.ui | 121 +++++++++++++++++++++++++++++++++---------------------------------------------------------------------------------------- >> virtManager/connection.py | 7 +++++++ >> virtManager/details.py | 37 ++++++++++++++++++++----------------- >> virtManager/domain.py | 17 ++++++++++------- >> virtinst/CPU.py | 9 +++++++++ >> virtinst/support.py | 5 +++++ >> 6 files changed, 84 insertions(+), 112 deletions(-) > > Thanks Guannan, pushed now. > > - Cole > > _______________________________________________ > virt-tools-list mailing list > virt-tools-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/virt-tools-list > _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
