On Sat, Apr 13, 2013 at 10:01:28AM -0400, Gene Czarcinski wrote: > I like what the referenced script does. Unfortunately, it works > with autotools and those have been removed from virt-manager and > replaced with python's distutils which has the same or at least > similar objectives but is definitely different. Iirc, this scrit just outputs a version number on stdin, so while the usage instructions are about an autotools based build system, I assume it should not be too difficult to adapt it to different needs/build systems. > > I like using a tag as the basis for "version." Unfortunately, this > is a bit difficult. AFAIK, you cannot set a tag via patch and > version is set from the value of the hardcoded and git tracked > virtcli/cliconfig.__version__ which has the current value of > "0.9.4". In addition, the tags which are used to identify the > commit which is the base (top level) for a release has the form of > RELEASE-0.0.0-1 ... a little string editing gets this to "0.0.0". I'm not sure what you are trying to get to here... You can - tweak the script to understand your tag format - replace the hardcoded version string in virtcli/cliconfig.__version__ with something that comes from the git-version-gen script Oh, or is #2 complicated to do? /me just glanced over the rest of the email. > > While I like the information provided by git-describe--tags, it does > not necessarily produce an increasing number. Consider a base with > the tag of "0.9.100". Now have two branches off that. I basically stopped reading here :) Yeah, if you start considering branches, things get harder, but I rather stay with a simple solution with known caveats rather than something more complicated/invasive. > The git-describe--tags information would > (IMHO) be good for an internal "version" but not when used for the > version-id in a sdist-tarball or an rpm. Right now, I am not going > to worry about git-describe--tags and a potention internale > version-id. Not sure if you are talking about the git-version-gen script, or just the built-in git describe command. The git-version-gen script gives you a nice version number as soon as your HEAD corresponds to a tag. Christophe
Attachment:
pgppPdiZFJagG.pgp
Description: PGP signature
_______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
