The patches includes in this set have responded to the comments received. In most, if not all, cases, the recommended changes were made. I guess I finally got things correct with autobuild.sh because Daniel gave an "ACK" to this version. The patch files included in this update set are related but (mostly) do not depend on each other for installation or order of application. However, the "version" patch does depend on the "wrapper" patch because of changes to virt-manager.spec 1. Fix setup.py so that the /usr/bin wrapper executables work. 2. Minor clarification, etc. update for INSTALL. 3. Add MANIFEST.in to control what is and what is not included in the sdist tarball. 4. Update autobuild.sh so that it works. Provision is made for the version-id change so that there is no impact on the autobuild naming/versioning for rpms. NOTE: After autobuild.sh runs, a git-reset--hard is currently needed because setup.py-build modifies po/virt-manager.pot. 5. By far the largest update is the change to the virt-manager version id. An "external" id is used for the sdist-tarball and RPMs with a separate "internal" version providing more info from git-describe--tags. It is not clear what the next (gtk3 based) release will be called ... 0.10.0? ... 1.0.0? Perhaps the current cliconfig.__version__ could be updated to something like 0.9.100 to reflect the pre-release development status. It would also be appreciated if this "id" was set to a git-tag which would be helpful for the version-id change/update ... currently, if tag is used it is "0.9.5". Yes, "RELEASE-" prefix and "-1" suffix are removed. Concerning specifics about the version-ids ... I am flexible if somewhat different formats make more sense. Many/most of the other projects I have delt with use a snapshot of the form <version>.gitYYYYMMDD. Gene Czarcinski (5): minor updates and changes to the INSTALL file add MANIFEST.in to specify includes and excludes make wrapper executables work make autobuild.sh work virt-manager version-id changes .gitignore | 3 + INSTALL | 15 +- MANIFEST.in | 26 ++ autobuild.sh | 12 +- setup.py | 41 +- tests/cli-test-xml/compare/cpuset-auto.xml | 4 +- tests/storage-xml/pool-logical-vol.xml | 2 +- tests/storage-xml/pool-logical-volclone.xml | 2 +- tests/storage-xml/pool-logical-volinput.xml | 2 +- tests/xmlconfig-xml/boot-cpuset.xml | 2 +- tests/xmlparse-xml/change-hostdevs-out.xml | 2 +- tests/xmlparse.py | 2 +- virt-manager | 6 +- virt-manager-tui | 2 +- virt-manager.spec | 611 --------------------------- virt-manager.spec.in | 612 ++++++++++++++++++++++++++++ virtcli/cliconfig.py | 120 +++++- virtinst/Storage.py | 10 +- virtinst/cli.py | 2 +- 19 files changed, 836 insertions(+), 640 deletions(-) create mode 100644 MANIFEST.in delete mode 100644 virt-manager.spec create mode 100644 virt-manager.spec.in -- 1.8.1.4 _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
