On Mon, Feb 11, 2013 at 02:19:57PM +0100, Christophe Fergeau wrote:
> On Mon, Feb 11, 2013 at 01:10:23PM +0000, Daniel P. Berrange wrote:
> > This looks very wrong to me - 'release' is not something that
> > should be visible to configure.ac - its is purely an RPM level
> > concept. Why are you munging congfigure in this way ?
>
> I think the goal is to have a more fine-grained version number in
> virt-viewer about dialog, --version, ... so that we have an easier way to
> track exactly what build is being used.
For something like that I'd suggest we don't munge the configure.ac
version string. Add a 'BUILDID' variable to src/Makefile.am and set
that during the RPM build
%make BUILDID=%{release}
And make sure the about dialog includes the version from configure,
with the BUILDID appended
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
_______________________________________________
virt-tools-list mailing list
virt-tools-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/virt-tools-list
