On Mon, Feb 11, 2013 at 02:04:51PM +0100, Christophe Fergeau wrote: > On Tue, Jan 29, 2013 at 04:56:44PM +0100, Marc-André Lureau wrote: > > This is a proposed solution related to: > > https://bugzilla.redhat.com/show_bug.cgi?id=905268 > > --- > > mingw-virt-viewer.spec.in | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/mingw-virt-viewer.spec.in b/mingw-virt-viewer.spec.in > > index 6fdb8b5..cdbb6be 100644 > > --- a/mingw-virt-viewer.spec.in > > +++ b/mingw-virt-viewer.spec.in > > @@ -1,4 +1,5 @@ > > %{?mingw_package_header} > > +%{!?enable_autotools:%define enable_autotools 1} > > > > Name: mingw-virt-viewer > > Version: @VERSION@ > > @@ -44,6 +45,13 @@ BuildRequires: mingw32-nsis > > BuildRequires: hicolor-icon-theme > > BuildRequires: gnome-icon-theme > > > > +%if 0%{?enable_autotools} > > +BuildRequires: autoconf > > +BuildRequires: automake > > +BuildRequires: gettext-devel > > +BuildRequires: libtool > > +%endif > > + > > BuildArch: noarch > > > > %package -n mingw32-virt-viewer > > @@ -84,6 +92,11 @@ MinGW Windows virt-viewer installer > > > > > > %build > > +%if 0%{?enable_autotools} > > +sed -i "s/^AC_INIT.*/AC_INIT([virt-viewer], [$RPM_PACKAGE_VERSION-$RPM_PACKAGE_RELEASE])/" configure.ac > > +autoreconf -if > > +%endif > > + > > Hmm quite ugly :-/ I'd tend to patch config.h after running > %mingw_configure if we go this road, this is differently ugly, no idea if > this is better This looks very wrong to me - 'release' is not something that should be visible to configure.ac - its is purely an RPM level concept. Why are you munging congfigure in this way ? Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| _______________________________________________ virt-tools-list mailing list virt-tools-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/virt-tools-list
