On Sat, Nov 10, 2012 at 5:06 PM, Daniel P. Berrange <berrange@xxxxxxxxxx> wrote: > > On Sat, Nov 10, 2012 at 11:57:05AM +0100, Zeeshan Ali (Khattak) wrote: > > Hi Daniel, > > I see that there is a 'product-key-format' property in > > OsinfoInstallScript class. Currently no script provide a value for it > > so I > > don't know whats the intended format of this string. Is this prop a > > string > > by mistake? IIRC some of Fabiano's changes were merged into your patches > > so > > I'm not sure `git blame` is correct here. Would be good to decide this > > anyways so I can correct this or document the format and set this from > > the > > scripts. > > IIRC the idea was that it would be used to illustrate the key chunking > format. eg > > ####-####-####-#### > > so that apps could provide text entry fields of the right size for the > OS in question. Ah ok so nothing too generic then. Haven't yet figured how Boxes can make use of this but looking at the current code we have [1] for this, this API is probably going to suffice. -- Regards, Zeeshan Ali (Khattak) FSF member#5124 [1] http://git.gnome.org/browse/gnome-boxes/tree/src/winxp-installer.vala#n129
