On Sat, Nov 10, 2012 at 11:57:05AM +0100, Zeeshan Ali (Khattak) wrote: > Hi Daniel, > I see that there is a 'product-key-format' property in > OsinfoInstallScript class. Currently no script provide a value for it so I > don't know whats the intended format of this string. Is this prop a string > by mistake? IIRC some of Fabiano's changes were merged into your patches so > I'm not sure `git blame` is correct here. Would be good to decide this > anyways so I can correct this or document the format and set this from the > scripts. IIRC the idea was that it would be used to illustrate the key chunking format. eg ####-####-####-#### so that apps could provide text entry fields of the right size for the OS in question. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|