On Fri, Oct 26, 2012 at 6:52 PM, Zeeshan Ali (Khattak) <zeeshanak@xxxxxxxxx> wrote: > On Fri, Oct 26, 2012 at 6:30 PM, Eric Blake <eblake@xxxxxxxxxx> wrote: >> On 10/25/2012 08:20 PM, Zeeshan Ali (Khattak) wrote: >>> From: "Zeeshan Ali (Khattak)" <zeeshanak@xxxxxxxxx> >>> >>> Note that we are calling bindtextdomain() from Loader's class init. >>> AFAICT, its a common practice in libraries without any main _init() >>> function to make this call in init of the most common/useful class (e.g >>> gdk-pixbuf and gdbus). >>> --- >>> .gitignore | 15 +++++++++++++++ >>> Makefile.am | 28 +++++++++++++++++++++++++++- >>> autogen.sh | 1 + >>> configure.ac | 10 ++++++++++ >>> osinfo/Makefile.am | 1 + >>> osinfo/osinfo_loader.c | 4 ++++ >>> po/LINGUAS | 1 + >> >> I don't think you want po/LINGUAS in the .git repo (at least by >> comparison, neither coreutils nor libvirt version controls it). >> >>> tools/Makefile.am | 1 + >>> tools/osinfo-db-validate.c | 7 +++++++ >>> tools/osinfo-detect.c | 7 +++++++ >>> tools/osinfo-install-script.c | 7 +++++++ >>> tools/osinfo-query.c | 7 +++++++ >>> 12 files changed, 88 insertions(+), 1 deletion(-) >>> create mode 100644 po/LINGUAS >>> create mode 100644 po/POTFILES.in >>> create mode 100644 po/POTFILES.skip >> >> I've never seen POTFILES.skip used before. > > Look under GNOME git and you'll find plenty of examples for both of > these. :) Not sure if they are actually needed or just some historical > cruft thats been copy&pasted. I just removed the files and did a clean build/install and nothing breaks so I'll remove these files. -- Regards, Zeeshan Ali (Khattak) FSF member#5124
