On Mon, Oct 22, 2012 at 9:47 AM, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > Hey, > > Patch looks good, one question below: > > On Sat, Oct 20, 2012 at 01:21:10AM +0200, Marc-André Lureau wrote: >> +Function .onInit >> +retry: >> + System::Call 'kernel32::CreateMutexA(i 0, i 0, t "VirtViewerMutex") i .r1 ?e' > > I don't really understand the i.r1 here, is it needed? > http://nsis.sourceforge.net/Allow_only_one_installer_instance also warns It is needed to receive the handle, and be able to close it, so we can recreate it again when retrying, without incrementing it's usage > against CreateMutexA when using a unicode nsis, have you checked the mutex > name or are you sure we are not using a unicode nsis? At least I have checked it works, so I assume there is no issue there. -- Marc-André Lureau
