Looks good, ACK.
Wouldn't this error have been caught earlier if there was error checking
in this code?
Christophe
On Sat, Oct 20, 2012 at 12:57:26AM +0200, Marc-André Lureau wrote:
> ---
> src/remote-viewer-main.c | 2 +-
> src/windows-cmdline-wrapper.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/remote-viewer-main.c b/src/remote-viewer-main.c
> index f92ef13..2a8973d 100644
> --- a/src/remote-viewer-main.c
> +++ b/src/remote-viewer-main.c
> @@ -233,7 +233,7 @@ main(int argc, char **argv)
> if (AttachConsole(ATTACH_PARENT_PROCESS) != 0) {
> freopen("CONIN$", "r", stdin);
> freopen("CONOUT$", "w", stdout);
> - freopen("CONERR$", "w", stderr);
> + freopen("CONOUT$", "w", stderr);
> dup2(fileno(stdin), STDIN_FILENO);
> dup2(fileno(stdout), STDOUT_FILENO);
> dup2(fileno(stderr), STDERR_FILENO);
> diff --git a/src/windows-cmdline-wrapper.c b/src/windows-cmdline-wrapper.c
> index 510763b..704e2d7 100644
> --- a/src/windows-cmdline-wrapper.c
> +++ b/src/windows-cmdline-wrapper.c
> @@ -30,7 +30,7 @@
> * if (AttachConsole(ATTACH_PARENT_PROCESS) != 0) {
> * freopen("CONIN$", "r", stdin);
> * freopen("CONOUT$", "w", stdout);
> - * freopen("CONERR$", "w", stderr);
> + * freopen("CONOUT$", "w", stderr);
> * dup2(fileno(stdin), STDIN_FILENO);
> * dup2(fileno(stdout), STDOUT_FILENO);
> * dup2(fileno(stderr), STDERR_FILENO);
> --
> 1.7.11.7
>
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/virt-tools-list
Attachment:
pgpYvO6UtVY0d.pgp
Description: PGP signature
