On Thu, Jan 19, 2012 at 05:10:50PM +0200, Zeeshan Ali (Khattak) wrote:
> On Thu, Jan 19, 2012 at 11:25 AM, Daniel P. Berrange
> <berrange@xxxxxxxxxx> wrote:
> > On Thu, Jan 19, 2012 at 02:37:05AM +0200, Zeeshan Ali (Khattak) wrote:
> >> From: "Zeeshan Ali (Khattak)" <zeeshanak@xxxxxxxxx>
> >>
> >> Don't know how this had gone unnoticed for 4 releases now.
> >> ---
> >> osinfo/libosinfo.syms | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/osinfo/libosinfo.syms b/osinfo/libosinfo.syms
> >> index 18415e0..de1ff18 100644
> >> --- a/osinfo/libosinfo.syms
> >> +++ b/osinfo/libosinfo.syms
> >> @@ -1,4 +1,4 @@
> >> -LIBOSINFO_0.0.1 {
> >> +LIBOSINFO_0.0.6 {
> >> global:
> >> osinfo_db_get_type;
> >> osinfo_db_new;
> >
> > Ordinarily we should never change this. The only reason we
> > have changed it in libvirt-glib, is because we have been
> > intentionally breaking the API with each release so far.
> >
> > So I don't think we have a reason todo this in libosinfo
>
> The only reason I came to notice this was that I added a new function
> and it wasn't appearing in the symbols list of .so file. Once I fixed
> this, it was all of a suddenly getting there.
If adding a new function, you should just create a new block for it, eg
LIBOSINFO_0.0.6 {
global:
osinfo_new_func;
} LIBOSINFO_0.0.1;
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
