Re: util-linux fails to build on alpha due to test_enosys

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Thomas!

On Fri, 2023-12-01 at 09:50 +0100, Thomas Weißschuh wrote:
> thanks for the report!

Thanks a lot for the very quick action!

> On 2023-12-01 09:17:20+0100, John Paul Adrian Glaubitz wrote:
> > Since version 2.39.2, util-linux fails to build from source since tests/helpers/test_enosys.c
> > is built even though alpha is not supported by libseccomp and does not have AUDIT_ARCH_NATIVE:
> > 
> > gcc -DHAVE_CONFIG_H -I.  -include config.h -I./include -DLOCALEDIR=\"/usr/share/locale\" -D_PATH_RUNSTATEDIR=\"/run\" -D_PATH_SYSCONFSTATICDIR=\"/usr/lib\"   -Wdate-time -D_FORTIFY_SOURCE=2 -fsigned-
> > char -fno-common -Wall -Wextra -Waddress-of-packed-member -Wdiscarded-qualifiers -Wimplicit-function-declaration -Wmissing-declarations -Wmissing-parameter-type -Wmissing-prototypes -Wnested-externs -
> > Wno-missing-field-initializers -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wsign-compare -Wstrict-prototypes -Wtype-limits -Wuninitialized -Wunused-but-set-parameter -Wunused-but-set-
> > variable -Wunused-parameter -Wunused-result -Wunused-variable -Werror=sequence-point -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -Wformat -Werror=format-security -c -o tests/helpers/test_enosys.o
> > tests/helpers/test_enosys.c
> > In file included from tests/helpers/test_enosys.c:30:
> > ./include/audit-arch.h:67:6: error: #error Unknown target architecture
> >    67 | #    error Unknown target architecture
> >       |      ^~~~~
> > 
> > Full log available in [1].
> > 
> > Sam James from Gentoo suggested this might due to test_enosys being built unconditionally [2]
> > while enosys requires AUDIT_ARCH_NATIVE [3]. On the other hand, we're not seeing this issue
> > on sparc64 which currently doesn't have libseccomp support either.
> 
> Some clarifications:
> 
> test_enosys on the master branch is not the same as test_enosys in the
> 2.39.2 release.
> The old test_enosys got promoted to a proper "enosys" utility and
> test_enosys is now only a very simple test helper for that that has no
> platform dependencies.
> So the provided links are a bit off.
> 
> libseccomp is not involved at all.
> ensys does seccomp the hard way.
> 
> > 
> > Any suggestions?
> 
> Please try [0] on top of 2.39.2.
> 
> And maybe also [1] with the misc/enosys testsuite on top of master.
> 
> [0] https://github.com/util-linux/util-linux/pull/2612
> [1] https://github.com/util-linux/util-linux/pull/2613 

Will do and report back!

Thanks!

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913





[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux