Re: util-linux fails to build on alpha due to test_enosys

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Adrian,

thanks for the report!

On 2023-12-01 09:17:20+0100, John Paul Adrian Glaubitz wrote:
> Since version 2.39.2, util-linux fails to build from source since tests/helpers/test_enosys.c
> is built even though alpha is not supported by libseccomp and does not have AUDIT_ARCH_NATIVE:
> 
> gcc -DHAVE_CONFIG_H -I.  -include config.h -I./include -DLOCALEDIR=\"/usr/share/locale\" -D_PATH_RUNSTATEDIR=\"/run\" -D_PATH_SYSCONFSTATICDIR=\"/usr/lib\"   -Wdate-time -D_FORTIFY_SOURCE=2 -fsigned-
> char -fno-common -Wall -Wextra -Waddress-of-packed-member -Wdiscarded-qualifiers -Wimplicit-function-declaration -Wmissing-declarations -Wmissing-parameter-type -Wmissing-prototypes -Wnested-externs -
> Wno-missing-field-initializers -Wold-style-definition -Wpointer-arith -Wredundant-decls -Wsign-compare -Wstrict-prototypes -Wtype-limits -Wuninitialized -Wunused-but-set-parameter -Wunused-but-set-
> variable -Wunused-parameter -Wunused-result -Wunused-variable -Werror=sequence-point -g -O2 -ffile-prefix-map=/<<PKGBUILDDIR>>=. -Wformat -Werror=format-security -c -o tests/helpers/test_enosys.o
> tests/helpers/test_enosys.c
> In file included from tests/helpers/test_enosys.c:30:
> ./include/audit-arch.h:67:6: error: #error Unknown target architecture
>    67 | #    error Unknown target architecture
>       |      ^~~~~
> 
> Full log available in [1].
> 
> Sam James from Gentoo suggested this might due to test_enosys being built unconditionally [2]
> while enosys requires AUDIT_ARCH_NATIVE [3]. On the other hand, we're not seeing this issue
> on sparc64 which currently doesn't have libseccomp support either.

Some clarifications:

test_enosys on the master branch is not the same as test_enosys in the
2.39.2 release.
The old test_enosys got promoted to a proper "enosys" utility and
test_enosys is now only a very simple test helper for that that has no
platform dependencies.
So the provided links are a bit off.

libseccomp is not involved at all.
ensys does seccomp the hard way.

> 
> Any suggestions?

Please try [0] on top of 2.39.2.

And maybe also [1] with the misc/enosys testsuite on top of master.

[0] https://github.com/util-linux/util-linux/pull/2612
[1] https://github.com/util-linux/util-linux/pull/2613 

> > [1] https://buildd.debian.org/status/fetch.php?pkg=util-linux&arch=alpha&ver=2.39.2-1&stamp=1692576237&raw=0
> > [2] https://github.com/util-linux/util-linux/blob/master/meson.build#L3414
> > [3] https://github.com/util-linux/util-linux/blob/master/meson.build#L2947

Thomas




[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux