On 4/14/20 3:18 PM, Aurélien Lajoie wrote:
On Tue, Apr 14, 2020 at 1:38 PM Karel Zak <kzak@xxxxxxxxxx> wrote:
On Mon, Apr 13, 2020 at 10:41:34PM +0200, Aurélien Lajoie wrote:
As I have announced few days ago, I have started to work on ncal like for cal.
I have push a first working version on my github:
https://github.com/utix/util-linux/commits/cal_column
Is the option --column the best name? We use "column" pretty often to
address output in columns or number of columns, etc.
What about --vertical?
sure, no preference for me, ( -v is not used )
How or who decides this kind of stuff (sorry I am a newbie)
Does anyone know which locale can have some width issue ?
LC_ALL=ja_JP.utf8 cal
or another with multibyte letters.
ja_JP seems very compact, I think mongolian locale is a good one with month like
Арванхоёрдугаар сар
ja_JP is:
2020
1月 2月 3月
日 月 火 水 木 金 土 日 月 火 水 木 金 土 日 月 火 水 木 金 土
1 2 3 4 1 1 2 3 4 5 6 7
5 6 7 8 9 10 11 2 3 4 5 6 7 8 8 9 10 11 12 13 14
12 13 14 15 16 17 18 9 10 11 12 13 14 15 15 16 17 18 19 20 21
19 20 21 22 23 24 25 16 17 18 19 20 21 22 22 23 24 25 26 27 28
26 27 28 29 30 31 23 24 25 26 27 28 29 29 30 31
4月 5月 6月
日 月 火 水 木 金 土 日 月 火 水 木 金 土 日 月 火 水 木 金 土
1 2 3 4 1 2 1 2 3 4 5 6
5 6 7 8 9 10 11 3 4 5 6 7 8 9 7 8 9 10 11 12 13
12 13 14 15 16 17 18 10 11 12 13 14 15 16 14 15 16 17 18 19 20
19 20 21 22 23 24 25 17 18 19 20 21 22 23 21 22 23 24 25 26 27
26 27 28 29 30 24 25 26 27 28 29 30 28 29 30
31
7月 8月 9月
日 月 火 水 木 金 土 日 月 火 水 木 金 土 日 月 火 水 木 金 土
1 2 3 4 1 1 2 3 4 5
5 6 7 8 9 10 11 2 3 4 5 6 7 8 6 7 8 9 10 11 12
12 13 14 15 16 17 18 9 10 11 12 13 14 15 13 14 15 16 17 18 19
19 20 21 22 23 24 25 16 17 18 19 20 21 22 20 21 22 23 24 25 26
26 27 28 29 30 31 23 24 25 26 27 28 29 27 28 29 30
30 31
10月 11月 12月
日 月 火 水 木 金 土 日 月 火 水 木 金 土 日 月 火 水 木 金 土
1 2 3 1 2 3 4 5 6 7 1 2 3 4 5
4 5 6 7 8 9 10 8 9 10 11 12 13 14 6 7 8 9 10 11 12
11 12 13 14 15 16 17 15 16 17 18 19 20 21 13 14 15 16 17 18 19
18 19 20 21 22 23 24 22 23 24 25 26 27 28 20 21 22 23 24 25 26
25 26 27 28 29 30 31 29 30 27 28 29 30 31
I have tried to keep the same structure of the code between the column
mode and the row mode.
It is impossible to keep line width lower than 80.
Do you mean source code line? ... 80 is not a strict rule, keep it
readable.
Yes speaking about code line, with tab width set to 8, 80 is quickly reached.
Don't use a tab width of 8. Research has shown that the most readable
level of code indentation is between 2 and 4 characters. Personally I
use 3.
-- Bruce
I can try to split the big function `cal_output_months` this will make
it more readable, but will introduce a lot of change for no feature.
Any advice on this ?
Your cal_col_output_months() does not look like any huge monster.
I have added one comment to your commits/cal_column at github.
Thanks I will do the modification
Karel
--
Karel Zak <kzak@xxxxxxxxxx>
http://karelzak.blogspot.com
