On Mon, Apr 13, 2020 at 10:41:34PM +0200, Aurélien Lajoie wrote: > As I have announced few days ago, I have started to work on ncal like for cal. > I have push a first working version on my github: > https://github.com/utix/util-linux/commits/cal_column Is the option --column the best name? We use "column" pretty often to address output in columns or number of columns, etc. What about --vertical? > I will now add some tests, and improve my code. Cool. > Does anyone know which locale can have some width issue ? LC_ALL=ja_JP.utf8 cal or another with multibyte letters. > I have tried to keep the same structure of the code between the column > mode and the row mode. > It is impossible to keep line width lower than 80. Do you mean source code line? ... 80 is not a strict rule, keep it readable. > I can try to split the big function `cal_output_months` this will make > it more readable, but will introduce a lot of change for no feature. > Any advice on this ? Your cal_col_output_months() does not look like any huge monster. I have added one comment to your commits/cal_column at github. Karel -- Karel Zak <kzak@xxxxxxxxxx> http://karelzak.blogspot.com
