Re: [PATCH] losetup: Add support for logical block size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 27, 2017 at 02:48:11PM +0200, Stanislav Brabec wrote:
> Karel Zak wrote:
> > Merged (with fixed get() function).
> > 
> > I'm not sure about the "BLOCKSIZE" column name. For lsblk we use
> > "LOG-SEC" (and "PHY-SEC"), it seems more explicit and shorter. What
> > about to use the same column name for losetup too? From my point of
> > view "BLOCKSIZE" is too vague it would be nice to minimize differences
> > in terminology used by the tools (losetup and lsblk).
> 
> It makes sense.
> 
> > Maybe we can also rename "--logical-blocksize" to "--log-sector".
> > 
> Maybe. But --log-* can associate logging. What about --logical-size or
> --sector-size or only --sectors?

OK, renamed to LOG-SEC and to --sector-size. We already use --sector-size
for fdisk and I guess we will never see configurable physical sector
size for loop devices.

    Karel

-- 
 Karel Zak  <kzak@xxxxxxxxxx>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe util-linux" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux